Skip to content

Comments

OCPCLOUD-2266: IBMCloud: MAPI Service Endpoint overrides#28

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
cjschaef:ocpcloud-2266
Nov 14, 2023
Merged

OCPCLOUD-2266: IBMCloud: MAPI Service Endpoint overrides#28
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
cjschaef:ocpcloud-2266

Conversation

@cjschaef
Copy link
Member

@cjschaef cjschaef commented Nov 6, 2023

Enable MAPI to override IBM Cloud Service endpoints from the
Infrastructure config.

Related: https://issues.redhat.com/browse/OCPCLOUD-2266

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2023

@cjschaef: This pull request references OCPCLOUD-2266 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Enable MAPI to override IBM Cloud Service endpoints from the
Infrastructure config.

Related: https://issues.redhat.com/browse/OCPCLOUD-2266

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Enable MAPI to override IBM Cloud Service endpoints from the
Infrastructure config.

Related: https://issues.redhat.com/browse/OCPCLOUD-2266
Update the IBM golang dependency packages and openshift/api
for IBMCloudServiceName's.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 1dda329 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 2bcc500 into openshift:main Nov 14, 2023
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibmcloud-machine-controllers-container-v4.15.0-202311141432.p0.g2bcc500.assembly.stream for distgit ose-ibmcloud-machine-controllers.
All builds following this will include this PR.

@cjschaef cjschaef deleted the ocpcloud-2266 branch November 28, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants